From 882dc805cf356b28b31493a3822cda152a0caa29 Mon Sep 17 00:00:00 2001 From: Romain Pluciennik Date: Fri, 16 Aug 2024 17:30:20 +0200 Subject: [PATCH] feat(it-tools): Change service port to 8080 (#8) * fix(actions): Add NET_BIND_SERVICE capability * test(it-tools): Remove capabilities options * feat(it-tools): Removed liveness & readiness probes * feat(actions): Update chart testing workflow * test(actions): Re-add probes & test security context * feat(it-tools): Changed service port to 8080 * feat(doc): Be more specific in the changelog --- .github/ct-install-config.yaml | 2 ++ .github/ct-lint-config.yaml | 2 ++ .github/workflows/lint-test.yaml | 12 +++++------- .github/workflows/release.yaml | 6 ++---- README.md | 1 + charts/it-tools/Chart.yaml | 4 ++-- charts/it-tools/README.md | 4 ++-- charts/it-tools/templates/common.yaml | 4 ++-- charts/it-tools/values.yaml | 2 +- 9 files changed, 19 insertions(+), 18 deletions(-) diff --git a/.github/ct-install-config.yaml b/.github/ct-install-config.yaml index 244e193..837c2f1 100644 --- a/.github/ct-install-config.yaml +++ b/.github/ct-install-config.yaml @@ -1,2 +1,4 @@ debug: true all: true +chart-repos: + - bjw-s=https://bjw-s.github.io/helm-charts diff --git a/.github/ct-lint-config.yaml b/.github/ct-lint-config.yaml index 08d2dbb..954478c 100644 --- a/.github/ct-lint-config.yaml +++ b/.github/ct-lint-config.yaml @@ -1,3 +1,5 @@ debug: true all: true validate-maintainers: false +chart-repos: + - bjw-s=https://bjw-s.github.io/helm-charts diff --git a/.github/workflows/lint-test.yaml b/.github/workflows/lint-test.yaml index 4e02223..bd78de4 100644 --- a/.github/workflows/lint-test.yaml +++ b/.github/workflows/lint-test.yaml @@ -1,4 +1,4 @@ -name: Lint and Test Charts +name: Linting and Testing on: push: @@ -24,9 +24,7 @@ jobs: uses: helm/chart-testing-action@v2.6.1 - name: Run chart-testing (lint) - run: | - helm repo add bjw-s https://bjw-s.github.io/helm-charts - ct lint --config .github/ct-lint-config.yaml + run: ct lint --config .github/ct-lint-config.yaml test: runs-on: ubuntu-latest @@ -50,9 +48,9 @@ jobs: fi - name: Create kind cluster + if: steps.list-changed.outputs.changed == 'true' uses: helm/kind-action@v1.10.0 - name: Run chart-testing (install) - run: | - helm repo add bjw-s https://bjw-s.github.io/helm-charts - ct install --config .github/ct-install-config.yaml + if: steps.list-changed.outputs.changed == 'true' + run: ct install --config .github/ct-install-config.yaml diff --git a/.github/workflows/release.yaml b/.github/workflows/release.yaml index b454f2c..39ab547 100644 --- a/.github/workflows/release.yaml +++ b/.github/workflows/release.yaml @@ -1,4 +1,4 @@ -name: Release Charts +name: Release on: workflow_dispatch: @@ -44,9 +44,7 @@ jobs: git config user.email "${{ env.AUTHOR_EMAIL }}" - name: Add Helm repos - run: | - helm repo add bitnami https://charts.bitnami.com/bitnami - helm repo add bjw-s https://bjw-s.github.io/helm-charts + run: helm repo add bjw-s https://bjw-s.github.io/helm-charts - name: Install chart-releaser uses: helm/chart-releaser-action@v1.5.0 diff --git a/README.md b/README.md index e53f4b7..eafd47e 100644 --- a/README.md +++ b/README.md @@ -6,6 +6,7 @@ +

# Charts diff --git a/charts/it-tools/Chart.yaml b/charts/it-tools/Chart.yaml index cf4a3f9..f414b9c 100644 --- a/charts/it-tools/Chart.yaml +++ b/charts/it-tools/Chart.yaml @@ -4,7 +4,7 @@ description: Collection of handy online tools for developers, with great UX. home: https://github.com/plcnk/charts/tree/master/charts/it-tools icon: https://raw.githubusercontent.com/plcnk/charts/master/charts/it-tools/icon.svg type: application -version: 2.0.0 +version: 2.1.0 # renovate datasource=docker depName=ghcr.io/corentinth/it-tools appVersion: "2024.5.13-a0bc346" kubeVersion: ">=1.22.0-0" @@ -21,7 +21,7 @@ sources: annotations: artifacthub.io/changes: |- - kind: changed - description: Major chart overhaul. Now using bjw-s's common library chart. + description: Changed service port from 80 to 8080 artifacthub.io/links: |- - name: App Source url: https://github.com/CorentinTh/it-tools diff --git a/charts/it-tools/README.md b/charts/it-tools/README.md index 5c5e456..cb313dc 100644 --- a/charts/it-tools/README.md +++ b/charts/it-tools/README.md @@ -2,7 +2,7 @@ it-tools logo -![Version: 2.0.0](https://img.shields.io/badge/Version-2.0.0-informational?style=flat) +![Version: 2.1.0](https://img.shields.io/badge/Version-2.1.0-informational?style=flat) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat) ![AppVersion: 2024.5.13-a0bc346](https://img.shields.io/badge/AppVersion-2024.5.13--a0bc346-informational?style=flat) @@ -11,7 +11,7 @@ Collection of handy online tools for developers, with great UX. **Homepage:** **This chart is not maintained by the upstream project and any issues with the chart should be raised -[here](https://github.com/plcnk/charts/issues/new?assignees=plcnk&labels=bug&template=bug_report.yaml&name=it-tools&version=2.0.0)** +[here](https://github.com/plcnk/charts/issues/new?assignees=plcnk&labels=bug&template=bug_report.yaml&name=it-tools&version=2.1.0)** ## Source Code diff --git a/charts/it-tools/templates/common.yaml b/charts/it-tools/templates/common.yaml index f9e315c..b1671f1 100644 --- a/charts/it-tools/templates/common.yaml +++ b/charts/it-tools/templates/common.yaml @@ -18,7 +18,7 @@ configMaps: include /etc/nginx/mime.types; server { - listen 80; + listen 8080; server_name _; root /usr/share/nginx/html; index index.html; @@ -59,7 +59,7 @@ controllers: containers: app: ports: - - containerPort: 80 + - containerPort: 8080 name: http protocol: TCP probes: diff --git a/charts/it-tools/values.yaml b/charts/it-tools/values.yaml index d3be3f0..b1262b4 100644 --- a/charts/it-tools/values.yaml +++ b/charts/it-tools/values.yaml @@ -62,7 +62,7 @@ service: controller: main ports: http: - port: 80 + port: 8080 # -- Configure persistence for the chart under this key. # @default -- See [values.yaml](./values.yaml)