Nil pointer dereference if status query fails #1

New Issue

bp99 · 2025-08-26T19:45:18Z

bp99 commented

2025-08-26 19:45:18 +00:00

This function in agones.go is buggy:

func reportStatus(state *sidecarState) {
	status, err := state.q3.GetStatus()
	if err != nil {
		slog.Error("Failed to get gameserer status from Quake3 client", "error", err)
	}

	if err := updatePlayersList(state, status.Players); err != nil {
		slog.Error("Error while updating player list", "error", err)
	}
}

because even if GetStatus returns an error, execution still continues with updatePlayersList, attempting to access .Players on a nil reference.

This function in `agones.go` is buggy: ```go func reportStatus(state *sidecarState) { status, err := state.q3.GetStatus() if err != nil { slog.Error("Failed to get gameserer status from Quake3 client", "error", err) } if err := updatePlayersList(state, status.Players); err != nil { slog.Error("Error while updating player list", "error", err) } } ``` because even if `GetStatus` returns an `error`, execution still continues with `updatePlayersList`, attempting to access `.Players` on a `nil` reference.

bp99 self-assigned this 2025-08-26 19:45:18 +00:00

bp99 added reference master

2025-08-26 19:45:21 +00:00

bp99 added the

bug

label 2025-08-26 19:46:03 +00:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: bp99/ut-agones#1